Skip to content

chore: fix some minor issues in comments #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liangmulu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: fix some minor issues in comments #5251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/charmeditor/src/extensions/listItem/applyMark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default function applyMark(
for (let i = 0; i < ranges.length; i++) {
const { $from, $to } = ranges[i];
// [FS] IRAD-1043 2020-10-27
// No need to remove the applied custom styles when select the custom style mutiple times.
// No need to remove the applied custom styles when select the custom style multiple times.
if (has && !isCustomStyleApplied) {
tr = tr.removeMark($from.pos, $to.pos, markType);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/charmeditor/src/extensions/listItem/commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export function removeList(): Command {
}
const { pos, node } = result;
if (from !== pos + 2) {
// Selection is not at the begining of the list item.
// Selection is not at the beginning of the list item.
return false;
}
if (node.childCount !== 1) {
Expand Down
2 changes: 1 addition & 1 deletion packages/charmeditor/src/extensions/listItem/czi-list.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
* Note that this CSS Rule will not work in MS-Edge 15:
* - MS-Edge 15 does not supported using CSS variable isnide pseudo element
* https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/11495448/
* - MS-Edge 15 does not supported nested CSS fucntions.
* - MS-Edge 15 does not supported nested CSS functions.
* https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/18936010/
* In order to support MS-Edge 15, we'd have to use extra rules.
* See the section "MS-Edge 15 Rules" below.
Expand Down
4 changes: 2 additions & 2 deletions packages/charmeditor/src/extensions/listItem/mergeListItems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function mergeListItemUp(tr: Transaction, schema: Schema): Transaction {
}
const { pos, node } = result;
if (from !== pos + 2) {
// Selection is not at the begining of the list item.
// Selection is not at the beginning of the list item.
return tr;
}
const $pos = tr.doc.resolve(pos);
Expand Down Expand Up @@ -77,7 +77,7 @@ export function mergeListItemDown(tr: Transaction, schema: Schema): Transaction
}
const { pos, node } = result;
if (from !== pos + node.content.size) {
// Selection is not at the begining of the list item.
// Selection is not at the beginning of the list item.
return tr;
}

Expand Down