fix: honor Set Framerate on overlay input streams - #771
Open
shoemoney wants to merge 1 commit into
Open
Conversation
The window bar and both margin-fill sources default to 25fps and sit in the *main* slot of their overlays, so ffmpeg clamps the whole render to 25fps no matter what `Set Framerate` says. Measured on a 50fps tape: 25fps/62 frames before, 50fps/123 frames after, with duration unchanged. Half of every captured frame was being discarded silently. MarginFill defaults to the theme background, so this affects every render, not only tapes that set a margin. Fixes charmbracelet#750
Author
|
Green against main and rebase-clean. Honors Set Framerate on overlay input streams. Ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The window bar and both margin-fill sources default to 25fps and sit in the main slot of their overlays, so ffmpeg clamps the whole render to 25fps no matter what
Set Frameratesays.Measured on a 50fps tape: 25fps/62 frames before, 50fps/123 frames after, with duration unchanged. Half of every captured frame was being discarded silently.
MarginFill defaults to the theme background, so this affects every render, not only tapes that set a margin.
Fixes #750
CONTRIBUTING.md.