Skip to content

fix: allow numeric output filenames#756

Open
puneetdixit200 wants to merge 1 commit into
charmbracelet:mainfrom
puneetdixit200:fix-output-numeric-filename
Open

fix: allow numeric output filenames#756
puneetdixit200 wants to merge 1 commit into
charmbracelet:mainfrom
puneetdixit200:fix-output-numeric-filename

Conversation

@puneetdixit200

Copy link
Copy Markdown

Fixes #62.

Summary

  • Allow Output paths that start with numeric lexer fragments, such as 1.gif.
  • Recombine adjacent numeric/string path tokens before determining the output extension.
  • Add parser regression coverage for numeric output filenames.

Tests

  • Red before fix: go test ./parser -run TestParseOutputNumericFilename -count=1 failed with Expected file path after output and invalid 1. / gif commands
  • go test ./parser -run TestParseOutputNumericFilename -count=1
  • go test ./parser -count=1
  • go test ./...
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow numeric filenames as output (1.gif)

1 participant