fix(tui): respect --style / config over GLAMOUR_STYLE env - #993
Open
arimu1 wants to merge 1 commit into
Open
Conversation
When GLAMOUR_STYLE was set to a valid value such as auto or dark, the TUI ignored -s / style from flags and config. Prefer an explicit non-auto style, then fall back to the env value (charmbracelet#953).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
runTUIpreviously applied the resolved CLI/configstyleonly whenGLAMOUR_STYLEfailed validation. A valid env value (includingautoordark) therefore ignored-s light/ configstylein TUI mode.Now an explicit non-
autostyle from flags/config wins; otherwise the env value is used, thenauto.Motivation and Context
Fixes #953.
How Has This Been Tested?
go test ./...Checklist
Made with Cursor