fix(cli): respect preserve-new-lines flag in CLI renderer - #985
Open
syf2211 wants to merge 1 commit into
Open
Conversation
CLI mode unconditionally applied glamour.WithPreservedNewLines(), ignoring the -n flag and config default. Match TUI behavior by only enabling the option when preserveNewLines is true. Related to charmbracelet#858
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLI mode always passed
glamour.WithPreservedNewLines(), ignoring the-nflag and config default.Motivation
TUI mode already respects
preserveNewLinesinui/pager.go, butexecuteCLIforced preserved newlines for every render. That made CLI output differ from TUI and contributed to glow #858 list rendering complaints.Changes
TestCLIPreserveNewLinesFlagto verify the default path collapses soft breaksTests
go test ./... -count=1— passNotes
Full fix for list soft breaks inside list items requires the companion glamour change in charmbracelet/glamour#580 and a follow-up dependency bump once released.
Related to #858