fix: use TokyoNight config for tokyo-night code rendering - #977
Open
s3onghyun wants to merge 1 commit into
Open
Conversation
GlamourStyle's code-block branch mapped the tokyo-night style to DraculaStyleConfig, so 'glow --style tokyo-night <codefile>' rendered code with Dracula colors instead of Tokyo Night. glamour exports a distinct TokyoNightStyleConfig; use it. Every other case maps to its own config. Signed-off-by: Seonghyun Hong <s3onghyun.hong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
In
GlamourStyle(style, isCode), the branch that builds aStyleConfigfor rendering pure code files (non-markdown extensions,isCode == true) mapstokyo-nightto the Dracula config:So
glow --style tokyo-night <codefile>renders code with Dracula colors instead of Tokyo Night. glamour exports a distinctstyles.TokyoNightStyleConfig(different palette), and every other case in the switch maps to its own config — tokyo-night is the lone copy-paste mistake.(Regular markdown rendering with
tokyo-nightis unaffected; it goes through glamour'sWithStylePath. This bug is specific to the code-file branch.)Fix
One line:
case styles.TokyoNightStyle:→styles.TokyoNightStyleConfig.Testing
Added
utils/utils_test.go: renders a code block withtokyo-nightanddracula(color forced viaCLICOLOR_FORCE) and asserts the output differs. Fails before the fix (identical output), passes after.go test ./utils/green.