feat: sort markdown files by directory depth - #959
Open
officialasishkumar wants to merge 1 commit into
Open
Conversation
The TUI file list sorted purely by note path, so markdown files in child directories could appear before files in the directory where Glow was launched. Rank discovered files by path depth first, then preserve the existing path sort within each depth so root-level documents are listed before nested documents. Fixes charmbracelet#272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sorts discovered TUI markdown files by directory depth before path/title ordering.
This keeps files in the directory where Glow is browsing ahead of files in nested folders, while preserving the existing alphabetical path sort for files at the same depth.
Testing
go test ./...go test -race -covermode atomic ./...git diff --checkFixes #272