feat: detect extensionless remote JSON responses - #958
Open
officialasishkumar wants to merge 1 commit into
Open
Conversation
Remote HTTP sources without file extensions were always treated as markdown, even when the server identified the payload as JSON. That made API endpoints render as prose instead of a highlighted code block. Record the HTTP Content-Type for remote sources and use JSON media types, including +json variants, as the code block language only when the URL has no extension. Fixes charmbracelet#910
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds JSON detection for remote HTTP sources that do not have a
.jsonextension.Glow already renders local
.jsonfiles and remote.jsonURLs as code. This records the HTTPContent-Typefor remote sources and treats extensionlessapplication/jsonand+jsonresponses as JSON code blocks, while keeping markdown extensions extension-first.Testing
go test ./...go test -race -covermode atomic ./...git diff --checkFixes #910