fix: search file parent after leaving TUI document - #957
Open
officialasishkumar wants to merge 1 commit into
Open
fix: search file parent after leaving TUI document#957officialasishkumar wants to merge 1 commit into
officialasishkumar wants to merge 1 commit into
Conversation
When Glow starts directly in TUI document mode, the file listing is never populated. Pressing escape returns to an empty stash view, and the local search path still points at the opened file instead of a searchable directory. Start the local file search when unloading an initially opened document, and resolve file paths to their parent directory before scanning. Fixes charmbracelet#803
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the empty file list shown after starting Glow directly on a file in TUI mode and pressing escape.
When Glow starts in document mode, the stash listing has not been populated yet. Unloading the document now starts the local file search, and file paths are resolved to their parent directory before scanning.
Testing
go test ./...go test -race -covermode atomic ./...git diff --checkFixes #803