fix: expand ~ in style path from glow.yml - #949
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
The validateStyle function was expanding the tilde on a local copy of the path but never returning the expanded value, so the outer style variable kept the literal `~/...` form. Glamour then failed to open the file at runtime with `no such file or directory`. Return the expanded path from validateStyle and use it at both call sites. Closes charmbracelet#713. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #713.
When
style:inglow.ymlstarts with~, glow fails to open it:validateStyledid callutils.ExpandPath, but only on the function-local copy of the parameter, so the expanded value never made it back to the outerstylepackage var. Glamour then tried to open the literal~/...path.Fix is to return the expanded path from
validateStyleand use that at both call sites (the CLI flow invalidateOptions, and the TUI flow inrunTUI). Built-in style names likeauto/dark/lightare returned unchanged.Added a
TestValidateStylecovering the built-in pass-through, the~-expansion happy path, and the error message when the file is missing (the message should show the expanded path, not the raw tilde).