fix(ansi): don't add a blank line before a leading reference link - #586
Open
larrasket wants to merge 1 commit into
Open
fix(ansi): don't add a blank line before a leading reference link#586larrasket wants to merge 1 commit into
larrasket wants to merge 1 commit into
Conversation
A link reference definition at the top of a document (for example "[id]: https://example.com" before the first heading) leaves an empty text block as the document's first child. That made the first heading or paragraph compute First=false and emit a leading newline, so the rendered output started with a stray blank line. Skip empty text blocks when deciding whether a node is the first rendered child, so a leading reference definition no longer changes the output. Fixes charmbracelet#304
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #304
Skip empty text blocks when deciding whether a node is the first rendered child, so a leading reference definition no longer changes the output.
CONTRIBUTING.md.