fix(ansi): keep enclosing style on inline code spans - #585
Open
larrasket wants to merge 1 commit into
Open
Conversation
CodeSpanElement didn't implement StyleOverrideRender, so an inline code span nested inside emphasis or strong lost the surrounding style and rendered without italics or bold. Add StyleOverrideRender so the enclosing style cascades onto the code span, the same way BaseElement and EmphasisElement already do. The four regenerated table goldens only drop a redundant no-op escape sequence around code spans; the rendered output is unchanged. Fixes charmbracelet#80
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeSpanElementdidn't implementStyleOverrideRender, an inline code span nested inside emphasis or strong lost the surrounding style and rendered without italics or bold. this addStyleOverrideRenderso the enclosing style cascades onto the code spanFixes #80
CONTRIBUTING.md.