fix(ansi): skip nil inline child renderers - #582
Open
syf2211 wants to merge 1 commit into
Open
Conversation
Guard emphasis, link, and table cell renderers against nil children when Goldmark nodes are unhandled by NewElement. Prevents panics when custom or extension inline nodes appear inside inline structures. Fixes charmbracelet#576
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard emphasis, link, and table cell renderers against nil children when Goldmark inline nodes are unhandled by
NewElement. This prevents panics when custom or extension inline nodes appear inside inline structures.Fixes #576
Motivation
When Glamour encounters unhandled or custom inline nodes (e.g. from Goldmark parser extensions),
NewElementfalls through to the default case and returns anElementwith a nilRenderer. That nil value is appended toChildrenslices for emphasis, links, and table cells. Callingchild.Render()on these nil interface values causes a nil pointer dereference panic.Changes
EmphasisElement.doRender,LinkElement.renderTextPart, andTableCellElement.Renderbefore invoking child renderersTests
go test ./ansi/ -run 'Test.*SkipsNilChildren' -v -count=1— PASSgo test ./... -count=1— PASSNotes
Warning: unhandled elementmessage and produce no output; this change only prevents the panic.