fix(ansi): apply conceal and faint style attributes when rendering text - #568
Open
troclaux wants to merge 2 commits into
Open
fix(ansi): apply conceal and faint style attributes when rendering text#568troclaux wants to merge 2 commits into
troclaux wants to merge 2 commits into
Conversation
troclaux
changed the title
The Conceal field of StylePrimitive was parsed from style JSON but never applied to the ANSI output. Text remained visible even when conceal: true was set (e.g. on link or link_text styles). Fixes charmbracelet#121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
concealfield ofStylePrimitivewas being parsed from style JSON but never applied to the ANSI output. Text remained fully visible even whenconceal: truewas configured (e.g. onlinkorlink_textstyles).All other style attributes (bold, italic, underline, blink, etc.) were already applied —
concealwas simply missing from the chain.Fix
Add a
rules.Concealcheck inrenderText, consistent with how all other style attributes are applied:Test
Added
styles/examples/conceal_linktest fixture: a link rendered with"link": {"conceal": true}. The golden file confirms that the URL is wrapped in\x1b[8m(the ANSI conceal sequence).Fixes #121