chore: remove redundant tokyo_night.json style file - #567
Open
troclaux wants to merge 1 commit into
Open
Conversation
styles/tokyo_night.json is an orphan left over from when the style key used an underscore. The style has long been registered as 'tokyo-night' (kebab-case) in DefaultStyles, and go generate ./... now only produces tokyo-night.json. The underscore variant is unreachable through the named-style lookup and causes confusion. Closes charmbracelet#518
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
styles/tokyo_night.jsonis an orphan left over from when the style key used an underscore. The style has since been registered as"tokyo-night"(kebab-case) inDefaultStyles, sogo generate ./...only ever producestokyo-night.json.The underscore variant is:
"tokyo-night"is in the map)tokyo-night.jsongo generateKeeping it around causes confusion (two files, same content, different names).
Closes #518