fix: make style/theme names case-insensitive - #562
Open
toller892 wants to merge 1 commit into
Open
Conversation
Style names like 'Dark', 'DARK', 'Tokyo-Night' now resolve correctly instead of returning 'style not found'. The lookup in getDefaultStyle normalizes the input to lowercase before matching against DefaultStyles. Fixes charmbracelet#323
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style names like
Dark,DARK,Tokyo-Nightnow resolve correctly instead of returningstyle not found. The lookup ingetDefaultStylenormalizes the input to lowercase before matching againstDefaultStyles.This means users can now use any casing when specifying built-in themes:
WithStandardStyle("Dark")✅ (previously failed)WithStylePath("TOKYO-NIGHT")✅ (previously failed)GLAMOUR_STYLE=Dracula✅ (previously failed)Fixes #323
Changes
glamour.go: Addedstrings.ToLower()togetDefaultStyle()lookupglamour_test.go: AddedTestCaseInsensitiveStyleNameandTestCaseInsensitiveStylePathcovering various casing patterns (lowercase, uppercase, mixed case, kebab-case variants)