fix(lsp): handle window/workDoneProgress/create to prevent server crash - #3445
Open
piakdev wants to merge 1 commit into
Open
fix(lsp): handle window/workDoneProgress/create to prevent server crash#3445piakdev wants to merge 1 commit into
piakdev wants to merge 1 commit into
Conversation
The client advertises window.workDoneProgress: true in its initialize capabilities (via powernap's makeClientCapabilities), which per the LSP spec grants servers permission to send window/workDoneProgress/create requests. However, no handler was registered for this method, so when a server actually sends it (e.g. typescript-language-server during project loading, before initialize returns), the request goes unanswered and the server treats the failure as fatal — crashing the whole language server process with an unhandled ResponseError. Reproduced with: typescript-language-server + typescript@5.9.3 in a workspace. lsp_symbols/lsp_references failed with "jsonrpc2: connection is closed" because the server had already died during initialize. Fix: - Add a no-op HandleWorkDoneProgressCreate handler that returns nil, matching the pattern of the existing no-op HandleWorkspaceConfiguration. - Register handlers before calling client.Initialize(), not after — servers may send this request during the initialize handshake itself, so registering afterward is too late for that window. Verified end to end against typescript-language-server 5.3.0: symbols and references now return correctly instead of crashing.
Contributor
|
Thank you for your submission. We really appreciate it! Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request comment same as the below format. I have read the Contributor License Agreement (CLA) and hereby sign the CLA. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.workDoneProgress: truein its initialize capabilities (via powernap'smakeClientCapabilities), which per the LSP spec grants servers permission to sendwindow/workDoneProgress/createrequests back to the client.typescript-language-serverduring project loading, beforeinitializeeven returns), the request goes unanswered and the server treats the failure as fatal — crashing the whole language server process with an unhandledResponseError.HandleWorkDoneProgressCreatehandler (same pattern as the existing no-opHandleWorkspaceConfiguration), and register handlers before callingclient.Initialize()instead of after — servers may send this request during the initialize handshake itself, so registering afterward is too late for that window.Repro
typescriptLSP server pointing attypescript-language-server --stdiofor.js/.tsfiles.typescript@5.9.3locally in a workspace (needed separately sincetypescript@7.xno longer shipstsserver.js— unrelated issue).lsp_symbols,lsp_references, etc.) against a file in that workspace.Before: server crashes during init with
ResponseError: no handler for method: window/workDoneProgress/create, subsequent LSP calls fail withjsonrpc2: connection is closed.After: server initializes successfully;
lsp_symbols/lsp_referencesreturn correct results.Test plan
lsp_symbolsandlsp_referencesagainst a real.jsfile withtypescript-language-serverconfigured — both returned correct results instead of crashing.go build ./internal/lsp/...compiles clean.