Skip to content

Changes needed to support settings API - #110

Open
cb-hareeshv wants to merge 1 commit into
mainfrom
feat/SSM-1064
Open

Changes needed to support settings API#110
cb-hareeshv wants to merge 1 commit into
mainfrom
feat/SSM-1064

Conversation

@cb-hareeshv

@cb-hareeshv cb-hareeshv commented Aug 28, 2026

Copy link
Copy Markdown

🚀 Pull Request Template

📘 Description

🧩 Related Issues / Tickets

Closes #IssueNumber

📂 Type of Change

  • ✨ Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧪 Test Improvement
  • 🔧 Refactor / Code Cleanup
  • ⚙️ Build / Tooling

🧪 How to Test

# Example:
./gradlew run --args="-i spec.json -l PHP_V4 -o ../chargebee-php/php/src"

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

Added `JAVA_RESERVED_WORDS` to support Java reserved-name detection. Updated `Java.getName` to append `_` when generated lower-camel-case names match Java reserved words. Other generated names remain unchanged.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

@snyk-io

snyk-io Bot commented Aug 28, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues
Secrets 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 1622cc14-2454-4dbb-b3f9-7b194c2aee85

📥 Commits

Reviewing files that changed from the base of the PR and between 4939173 and 202c670.

📒 Files selected for processing (2)
  • src/main/java/com/chargebee/sdk/java/Constants.java
  • src/main/java/com/chargebee/sdk/java/Java.java

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The generator adds a public Java reserved-word set and updates getName to append _ when a generated lower-camel-case name matches a reserved word.

Changes

Java name generation

Layer / File(s) Summary
Reserved-name handling
src/main/java/com/chargebee/sdk/java/Constants.java, src/main/java/com/chargebee/sdk/java/Java.java
Constants defines Java keywords and literals. getName appends _ to matching generated names.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 202c6

This localized change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Suggested reviewers: cb-alish

🚥 Pre-merge checks | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
  • Fix all pre-merge checks with AI

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant