fix(ci): explicit --provenance + ensure npm >= 11.5.1 - #9
Conversation
…ishing Last run failed with ENEEDAUTH despite OIDC env vars being available. Two likely causes: 1. Node 24's bundled npm may be < 11.5.1 (trusted publishing minimum) 2. npm might need explicit --provenance flag to engage OIDC Address both. --force on the upgrade avoids the promise-retry self-upgrade bug we hit earlier (only manifested with stale on-disk npm).
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
📝 WalkthroughWalkthroughThe release workflow's publish job now ensures npm version >= 11.5.1 before publishing, adding a diagnostic step and forced upgrade. The npm publish command includes a Changesnpm trusted publishing with provenance
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/release.yml (1)
90-94: ⚡ Quick winPin npm to
npm@^11.5.1instead ofnpm@latest.Using
npm@latestmakes the release pipeline vulnerable to unexpected failures when a future major npm version changes Node compatibility or CLI behavior. The workflow currently uses Node 24, which is compatible with npm 11.5.1 and later versions in the npm 11.x range (all versions 11.0.0–11.14.1 requirenode: ^20.17.0 || >=22.9.0). Pinning tonpm@^11.5.1keeps CI deterministic and ensures the pipeline remains predictable across releases, while still satisfying trusted publishing requirements.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release.yml around lines 90 - 94, Replace the workflow step labeled "Ensure npm >= 11.5.1" that currently runs "npm install -g --force npm@latest && npm --version" with a pinned install of the npm 11.x range (e.g., "npm install -g --force npm@^11.5.1 && npm --version") so the job uses a deterministic npm release; update the run command in that step to install npm@^11.5.1 instead of npm@latest.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/release.yml:
- Around line 90-94: Replace the workflow step labeled "Ensure npm >= 11.5.1"
that currently runs "npm install -g --force npm@latest && npm --version" with a
pinned install of the npm 11.x range (e.g., "npm install -g --force npm@^11.5.1
&& npm --version") so the job uses a deterministic npm release; update the run
command in that step to install npm@^11.5.1 instead of npm@latest.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9b59d77f-aa88-49e8-a328-67e067de9e02
📒 Files selected for processing (1)
.github/workflows/release.yml
Last run on master (after #8 merged) failed with
ENEEDAUTH. OIDC env vars are available but npm isn't engaging them.Two likely causes addressed:
npm install -g --force npm@lateststep.--forceavoids thepromise-retryself-upgrade bug we hit earlier (only triggered when in-place upgrading on top of a much older npm, which we no longer have on Node 24).--provenanceflag to engage OIDC trusted publishing, even though docs claim auto-detect.Adds a debug
npm --versionprint so we can see what version was on the runner if this still fails. Once it works, that debug step can be dropped.Summary by CodeRabbit
Release Notes