Add secrets manager integration for credential retrieval - #897
Conversation
|
I'll be fixing this later please wait before you check so every test and dependency is working fine! |
b16dbb2 to
cc2a73e
Compare
sduenas
left a comment
There was a problem hiding this comment.
Please check my initial comments. Also, my concern is this only makes perceval work if you use the backend command but not the library. Please evaluate if it makes sense to integrate it within fetch or other methods, or if on the other hand, developers should use grimoirelab toolkit instead.
cc2a73e to
447d0c2
Compare
447d0c2 to
f8cc53e
Compare
sduenas
left a comment
There was a problem hiding this comment.
Please fix the lint errors and add unit test for this functionality.
f8cc53e to
e658562
Compare
|
Getting those errors cause I think it's importing an old version of Toolkit from before it had the las PR changes, is that correct? Not sure how to deal with that or if I'm even correct, but not sure what to do with it. |
We fixed it in #900. Please rebase your branch. |
e658562 to
e98ca15
Compare
e98ca15 to
15eefe8
Compare
Linting errors should be fixed and made tests for the env functinoality. |
sduenas
left a comment
There was a problem hiding this comment.
Please check my comments. The tests fail because hvac is not installed.
15eefe8 to
9ae098e
Compare
|
Fix the poetry.lock file (needed to update some packages) and the testing now properly tests perceval functioning and not toolkit. |
jjmerchante
left a comment
There was a problem hiding this comment.
Overall, it looks good to me. Just some minor changes
d838165 to
4395645
Compare
|
So, I fixed the things you commented, but I am not sure how to proceed with the poetry.lock conflict. I updated poetry to match the version of main, but now I'm getting other conflicts and not sure if leaving it to you. Not fully understand what the problem is. |
4395645 to
80f0bf5
Compare
sduenas
left a comment
There was a problem hiding this comment.
Everything looks good to me now. However, would you mind to move the documentation from the README to a file on /docs/perceval? I think it's too long for the readme file. You can leave a brief description of its usage and the rest, move it to a file there. You can also link the file from the README for those who need more info.
Signed-off-by: Alberto Ferrer Sánchez <alberefe@gmail.com>
80f0bf5 to
1d4c666
Compare
|
Created a new docs file and linked to it from the README.md. |
Integrate Perceval with external secrets managers (Bitwarden, HashiCorp Vault) so credentials can be resolved at runtime instead of being passed as plain-text CLI arguments.
to BackendCommandArgumentParser