feat: route functions by system version - #89
Draft
uno-ko wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(systemVersion, method)./functions/:versionpath as authoritative, validate it against the request body, and returnversionMismatchfor conflicts or unsupported versions.@channel.io/app-sdk-server.Why
When AppStore introduces a new major system contract such as
v2, requests to/functions/v2must not be silently dispatched to v1 handlers or return v1 schemas. The SDK now preserves the incoming system version through ingress, discovery, and dispatch.Compatibility
v1./functions/:versionroute shape are unchanged.Validation
make verify(includes localized docs checks)./scripts/check-public-content.shgit diff --check