Repository navigation
Drafts stay with their document; Library restore/quote; deterministic popup tests - #85
Merged
Merged
Conversation
A draft typed while another plan loaded, or in a plan that was withdrawn, was filed under the other plan's drafts key. Each drafts object now keeps its own key, typing writes to the drafts the visible boxes came from, and a plan switch parks the view while the next plan loads. Adds a proof test for agent-annotate-5uy (does not reproduce on 2.28.0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s keep their quote (agent-annotate-b0f) Restore over unsaved editor text now asks with confirm(), the page's pattern for losing unsent work. The quoted phrase of an unsaved Library comment is kept per item in this browser, so a reload or item switch keeps it and Save posts it as selected_quote. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iting on the throttled opener (agent-annotate-hnc, agent-annotate-srw) hnc: the rail's redraw harvested the boxes on screen into the drafts of the document being drawn, so a tab switch copied Review card text into the plan's drafts. Card boxes now write to the drafts the cards were drawn from; the general feedback box and composer to those of the document on screen. srw: the new tab takes the foreground and headless Chrome throttles the opener behind it, which answered Playwright's after-click checks (hit-target stop, Page.enable) only when its own next timer fired, 0.2 s to over 30 s. The two popup tests click with no_wait_after and still require the tab to open on the expected URL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t-annotate-srw) Once another tab is in front, headless Chrome holds every answer the tab behind it owes Playwright (mouse-up ack, hit-target check, evaluate) until that tab's own next timer, 0.2 s to over 30 s. The link tests check the link is clickable and takes focus, then click it from a timer inside the page; the two-tab draft test reads from the first tab after bringing it to front. 40 consecutive runs of the ticket-link case and 20 of the two-tab case pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes for the page in the browser: drafts, Library, flaky popup tests.
agent-annotate-hnc: drafts filed under the wrong document
plan:ask-nicole-live's drafts.setDraftwrote todraftsKey(DOC)at the moment of writing.DOCchanges while another document loads, andPLAN_IDchanges when a plan is withdrawn. The rail's redraw also collected the boxes still on screen into the drafts of the document being drawn.tests/browser/test_draft_document_keys.pyagent-annotate-5uy: typed answer lost when a card is withdrawn
test_withdrawn_question_keeps_typed_answer_and_its_send_count(rail and document box, focus held).agent-annotate-b0f: Library
confirm(), as the page already does before deleting unsent work.selected_quote.tests/browser/test_library_drafts.pyagent-annotate-srw: flaky ticket-link test
Test runs
ruff checkclean.🤖 Generated with Claude Code