Repository navigation
Images: IMG id labels and a large viewer that comments on a spot - #78
Merged
Merged
Conversation
Every image shows IMG + the first hex of its file's sha256 (the hash its staged asset name starts with). A tap opens it large with pinch/wheel zoom; a tap there comments on that point, carrying the id to the rail, inbox and round answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The inbox line and round answers print IMG F665 (assets/f665…-flow.png) from the comment's target, so agents need no lookup rule; the SKILL.md notes are reverted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Chang rejected opening an image by tapping it. A tap on an image comments again, as before. Under each image, next to its IMG id, a magnifier button group opens it at exactly that share of its real pixels, from the original file when the preview lacks them, scrolling when larger than the screen; a tap there comments on that spot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
changl
marked this pull request as ready for review
November 1, 2026 01:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chang's request (2026-10-31): give every image a short, stable ID, and a way to view an image larger while still commenting on it. He rejected the first prototype (tap opens a full-size viewer) and asked for fixed scales of 25%, 50%, 75% and 100%.
What changes
IMG F665label. The ID is the first 4 hex characters of the image file's sha256, which is also the hash that starts a staged asset's file name (assets/f665a6bf0296-flow.png). It stays the same while the image does. If two different images on one page share 4 characters, both get 6.data-img(long_pages.image_ids), and older versions read it from the file name.plain_imagesstrips it again, so it never marks a section as changed.25% 50% 75% 100%opens the image at exactly that share of its real pixels; at 100%, one image pixel is one screen point.target.image,target.image_srcand the point. Its pin shows there and on the page image.annotate inboxline and round answers printIMG F665 (assets/f665a6bf0296-flow.png), using the path stored on the comment. Only paths underassets/orattachments/are printed. The rail card and the composer show the ID. Skill files are untouched.Proof
shared/agents/shots/image-view/.INDEX-3.mdwalks through the path step by step (v3-step-1..5), andINDEX-2.mdcovers the scales.tests/browser/test_image_view.py(WebKit, iPad) covers:Draft until Chang approves on his page.
🤖 Generated with Claude Code