Skip to content

Simplification step 5: remove offline page interface and feedback export - #76

Merged
changl merged 1 commit into
changl/nextfrom
changl/simplify-step5
Oct 31, 2026
Merged

changl merged 1 commit into
changl/nextfrom
changl/simplify-step5

Conversation

@changl

@changl changl commented Oct 31, 2026

Copy link
Copy Markdown
Owner

Removes the serverless reviewing interface and Export feedback action from newly generated snapshots. pagegen.build_html now emits only the document carrier that the server extracts; live controls continue to come from the shared shell.

Approved on project page card #7 (Remove it). Stacks on #74 / changl/next, including its merged lighter-load work (#75).

Removed:

  • The 1,466-line web/template.html UI/exporter and its substitution logic/offline-only fields.
  • Offline-template requirements in doctor/package checks.
  • The 309-line offline-template browser test file (five cases).

Kept:

  • The Review, Plans and archive document wrapper: title, safe registry, canvas sentinels and diagram asset reference. All three callers are updated.
  • Legacy extraction and legacy_routes.py, because historical pages and current route cleanup still use them.
  • Live proof attachment downloads and --standalone, which is the separate-project-page alias, unrelated to offline opening.

Read-only local audit: 15 registered page rows; 13 roots answered, all serving the universal shell, none the offline UI. Thirteen direct historical version URLs still serve previously baked snapshot bytes. Those files do not read the packaged template and are intentionally not rewritten; existing downloaded copies are not retroactively stripped. Root/static GETs only, with no live content/fingerprint writes or restarts. Repo searches found no offline-opening/Export feedback instructions in README, docs or packaged skills, and no offline CLI flags to remove.

Validation:

  • Full Python chunks: 704, 612 and 378 passed; 2 existing skips.
  • Full browser chunks: 103, 42 and 89 passed (234 cases); no failures/retries.
  • After restacking on updated next: 141 targeted unit checks and 22 lighter/history/extraction/registry browser cases passed.
  • Old/new wrappers produce byte-identical server-extracted content in Review, escaped Plan/registry and archive/diagram comparisons.
  • Ruff and diff whitespace checks pass. Historical extraction coverage remains, using a small representative baked fixture instead of the deleted template.

Diff against next: 9 files, 37 insertions and 1,820 deletions (1,783 net lines removed). No release, version bump, merge, install, live-page changes or M5 action.

@changl
changl marked this pull request as ready for review October 31, 2026 22:38
@changl
changl merged commit 3669670 into changl/next Oct 31, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant