Precise decimal#8
Open
rally25rs wants to merge 3 commits into
Open
Conversation
Default `decimal` parser rounds to tenth of a degree Celsius. For users converting to Fahrenheit, the full 1000'ths precision can be used and the rounding done after conversion. For example 19.250 C would be rounded to 19.3 C. If converted to F there is a 0.1 degree difference between these values, which may be significant depending on the application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
preciseDecimalparser that returns the un-rounded value from the temp probe.For my application, I intend to convert to Fahrenheit. I noticed that the decimal parser would round a value of 19.250 to 19.3. If converting to F, 19.250 => 66.65, and 19.3 => 66.74. This is almost a 0.1 degree difference due to rounding. A more precise conversion would be yielded from converting the full 19.250 precision number to F first, then perform rounding to the nearest tenth of a degree.