Skip to content

Fix the View CV button downloads file instead of previewing it - #45

Merged
chamals3n4 merged 1 commit into
chamals3n4:mainfrom
Krishmal2004:Patch
Jul 29, 2026
Merged

Fix the View CV button downloads file instead of previewing it#45
chamals3n4 merged 1 commit into
chamals3n4:mainfrom
Krishmal2004:Patch

Conversation

@Krishmal2004

@Krishmal2004 Krishmal2004 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

#35

Purpose

Briefly describe the purpose of this PR and the problem it solves.

Type of Change

  • Feature
  • Bug fix
  • Refactor
  • Documentation
  • Test improvement
  • CI/CD
  • Other

Changes Made

Screenshots (if applicable)

Testing

Describe how you tested these changes.

Test Steps

Results

  • All existing tests pass
  • New tests added (if applicable)
  • Manually verified functionality

Breaking Changes

  • No breaking changes
  • This PR introduces breaking changes

If yes, describe them:

Checklist

  • Code follows project conventions
  • Self-review completed
  • Documentation updated (if needed)
  • Tests added/updated (if needed)
  • No sensitive data or secrets included
  • Related issues linked

Related Issues

Closes #

Additional Notes

Summary by CodeRabbit

  • Enhancements
    • Improved the in-app resume preview experience when a candidate has uploaded a CV.
    • Preserved the existing “no CV uploaded” message for candidates without a resume.

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

@Krishmal2004 is attempting to deploy a commit to the chamalsena Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5382d06c-1ee4-4453-8396-6e2bf73651bb

📥 Commits

Reviewing files that changed from the base of the PR and between 14c6bba and d6c9f1a.

📒 Files selected for processing (1)
  • frontend/app/(dashboard)/candidates/[id]/_components/cv-sheet.tsx

📝 Walkthrough

Walkthrough

The candidate CV sheet now imports ResumeScrollView and uses it to render an available resume URL, replacing the previous iframe while leaving the sheet layout and empty-state fallback unchanged.

Changes

Resume preview

Layer / File(s) Summary
Replace iframe resume rendering
frontend/app/(dashboard)/candidates/[id]/_components/cv-sheet.tsx
Imports ResumeScrollView and renders it with candidate.resumeUrl when a resume is available; the existing fallback remains unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related issues

Possibly related PRs

  • chamals3n4/OpenATS#44 — Updates the same CV sheet to use ResumeScrollView instead of an inline iframe.

Suggested reviewers: chamals3n4

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly the template with placeholders and lacks actual purpose, changes, testing, and issue linkage details. Fill in the template with a real purpose, concrete changes made, testing steps/results, breaking-change status, and the correct related issue number.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: the CV now previews instead of downloading.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Warning

⚠️ This pull request shows signs of AI-generated slop (description_diff_mismatch, ai_padded_prose). It has been flagged by CodeRabbit slop detection and should be reviewed carefully.

@chamals3n4
chamals3n4 merged commit 58e9797 into chamals3n4:main Jul 29, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants