Add holistic keyboard shortcuts, macOS modifier compatibility, and shortcuts dialog - #2
Merged
Merged
Conversation
…ortcuts dialog Implement full keyboard navigation and shortcut actions across the UI: - Engine & Shortcuts: Add Selection::Model for tracking active channel and player selection. Map Cmd+Option on macOS (preventing screen reader Control+Option modifier collisions) and Ctrl+Alt on Windows/Linux for global actions (Sync, Chat, Connect, Mute All, Section focus, Direct channel jumps 1..9). - Shortcuts Help Dialog: Add ShortcutsDialog modal component accessible via Cmd+Option+H / Ctrl+Alt+H or '?'. Build cells as accessible juce::Label components with single-speech title metadata. - Accessible Titles: Append shortcut key names to primary accessible titles (setTitle) across all on-screen UI controls so screen readers announce shortcut names immediately upon tabbing. - Audits & Tests: Add unit tests in test/ShortcutsTests.cpp and audit state in test/AuditMain.cpp (100% test pass rate). - Documentation: Update docs/ACCESSIBILITY.md and website/docs/accessibility.md.
Contributor
Author
|
Hi @chalkwalk Do you need any more information from me in order to pull this in? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement full keyboard navigation and shortcut actions across the UI:
Selection::Modelfor tracking active channel and player selection. MappedCmd+Optionon macOS (preventing screen readerControl+Optionmodifier collisions) andCtrl+Alton Windows/Linux for global actions (Sync, Chat, Connect, Mute All, Section focus, Direct channel jumps 1..9).ShortcutsDialogmodal component accessible viaCmd+Option+H/Ctrl+Alt+Hor?. Built table cells as accessiblejuce::Labelcomponents with single-speech title metadata.setTitle) across all on-screen UI controls so screen readers announce shortcut names immediately upon tabbing.test/ShortcutsTests.cppand audited state intest/AuditMain.cpp(100% test pass rate).docs/ACCESSIBILITY.mdandwebsite/docs/accessibility.md.