Implement server table cell accessibility and keyboard navigation - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Implements screen reader accessibility (VoiceOver, NVDA/Narrator) and keyboard navigation for the public server list table in ServerBrowserDialog.
Why
The server list table drew cell text using direct canvas graphics (paintCell), leaving table rows unannounced for screen readers on macOS (VoiceOver) and preventing keyboard selection of servers using arrow keys or Enter. Returning accessible juce::Label components via refreshComponentForCell exposes proper titles and descriptions per cell, and implementing selectedRowsChanged enables arrow key navigation and keyboard connecting.
Checks
ctest --test-dir build --output-on-failurepasses./build/test/AntiphonAudit_artefacts/AntiphonAuditexits 0clang-formatclean on the files I touched(UI accessibility improvement for screen reader users; no user manual changes required)
Environment tested
macOS ARM64, Standalone app, 48 kHz. Tested with AntiphonAudit and VoiceOver.
Anything touching the audio thread?
No.