Fix Rust 2024 export-attribute breakage in rebuild-wasm - #1
Draft
cmoulliard with Copilot wants to merge 2 commits into
Draft
Fix Rust 2024 export-attribute breakage in rebuild-wasm#1cmoulliard with Copilot wants to merge 2 commits into
rebuild-wasm#1cmoulliard with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job 'rebuild-wasm'
Fix Rust 2024 export-attribute breakage in Jun 9, 2026
rebuild-wasm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebuild-wasmfailed after moving the WASM crate to Rust 2024 because exported FFI symbols still used#[no_mangle], which is now treated as an unsafe attribute. The workflow stopped inwasm-buildbefore regenerating downstream artifacts.Root cause addressed
wasm-build/src/lib.rsfrom#[no_mangle]to#[unsafe(no_mangle)]to match Rust 2024 requirements.Rust 2024 compatibility adjustment
#![allow(static_mut_refs)]for the existing single-threaded WASM global-handle pattern (PARSERS,TREES,NODES,RESULT_BUF) so the module continues compiling under the stricter edition lints without redesigning runtime state management.Representative change