[login] Follow-up fixes for OIDC SSO login (i18n + SSO buttons)#2054
Open
frankrousseau wants to merge 2 commits into
Open
[login] Follow-up fixes for OIDC SSO login (i18n + SSO buttons)#2054frankrousseau wants to merge 2 commits into
frankrousseau wants to merge 2 commits into
Conversation
PR cgwire#2051 added login_with_oidc / login_oidc to every locale with the English text, so non-English users saw English and the keys looked already translated (never flagged for translation). Mirror each locale's existing SAML strings (saml_idp_name -> oidc_idp_name). en.js is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
|
- The SAML button's no-IdP-name fallback called login.saml, a key that does not exist (it is login_saml), so it rendered the raw key. Point it at login.login_saml. OIDC already used the correct login.login_oidc. - Both SSO buttons bound is-loading to isLoginLoading (the credential-login spinner). They are <a> links doing a full-page redirect, so that state never reflects their own click — drop the inert binding. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
frankrousseau
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2051 (OIDC SSO login button).
Problems
login_with_oidc/login_oidcto all 11 non-English locales with the English text, so non-English users see English and the keys look already translated (never flagged for translation).login.saml, which does not exist — the key islogin_saml— so it renders the raw key. Latent: only hit when SAML is enabled without an IdP name.is-loadingtoisLoginLoading(the credential-login spinner), but they are<a>full-page redirects, so that state never reflects their own click.Solutions
saml_idp_name→oidc_idp_name);en.js(source of truth) unchanged.login.login_saml(OIDC already used the correctlogin.login_oidc).is-loadingbinding from both SSO buttons.