Skip to content

bootc-dev/bootc#2567: operator request #708

Closed

Description

@cgwalters-bot

The operator commented on bootc-dev/bootc#2567, a pull request cgwalters-bot did not open. Runs for it take this issue as their item and answer here; cgwalters-bot's comment there links to it.

cgwalters wrote (bootc-dev/bootc#2567 (comment)):

Yeah true, though this could be a followup too to not waste CI

Generated-by: https://github.com/cgwalters/#llms

Activity

  1. cgwalters-bot commented on Oct 17, 2026

    @cgwalters-bot
    CollaboratorAuthor

    Partial work. The run was stopped at a request, task or spending limit, or an error that ended the agent's turn before the task was done; this is what it handed back.

    Conclusion: no bot action is wanted. The comment is a conversational reply in a review thread, not a request to the bot: it has no /bot or @cgwalters-bot line, cgwalters already approved the PR as-is, and the author has since volunteered to do the follow-up himself (comment). Per D17 the bot does not push to, or open follow-ups on, bootc-dev PRs it did not open, so the follow-up is the author's.

    The underlying point is valid, with one caveat: the suggested simplification at crates/lib/src/install.rs:442 (thread) is not a pure refactor. Dropping the None from the tuple pattern would newly reject --stateroot default combined with a non-default config stateroot, a case the PR deliberately allows (doc comment at crates/lib/src/install.rs:423; the PR's own test asserts validate(None, Some("default"), Some("myroot")).is_ok()). A follow-up must decide that case and update the test.

    "Not waste CI" is concrete: the PR's required checks currently fail only because test-integration (centos-9, ostree, xfs, grub, bls, unsealed) hit a grub2-efi-x64-cc package-unavailable flake in the compose build (run 38262304345, 10/10 retries failed), unrelated to this change; each integration push costs hours.

    Read: bootc-dev/bootc#2567 (head 9cf1afad), its review thread and CI runs, and docs/operator-notes.md (D17, 2026-10-17).

    Generated-by: https://github.com/cgwalters/#llms

    Generated by dispatch · ◷

  2. locked as resolved and limited conversation to collaborators on Oct 18, 2026
  3. cgwalters-bot commented on Oct 18, 2026

    @cgwalters-bot
    CollaboratorAuthor

    ✅ dispatch ended well. Result: #708 (comment) The run was stopped at a limit (exit state 3); what it handed back is marked partial.

    (Run status from 2026-10-17T11:54:19Z, re-posted by the bot without the agent's own words. The original job-token comment was removed so this issue counts as collaborator-only input, tracker#738.)

    Generated-by: https://github.com/cgwalters/#llms

  4. cgwalters-bot commented on Oct 20, 2026

    @cgwalters-bot
    CollaboratorAuthor

    Closing: the run's conclusion above found no bot action wanted.

    Generated-by: https://github.com/cgwalters/#llms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions