Repository navigation
promote: run due promotions from the scheduled sweep, and say on the PR when an approval cannot promote #388
Description
Repo: cgwalters-bot/homegit
cgwalters approved cgwalters-forge/bootupd#2 on 2026-09-26 and again on 2026-10-05 and saw nothing happen. bot-promote-due knew why (coreos/bootupd is human-text, so it needs his text and /promote --human-text), but that only appears in the sweep's watch.txt, which he does not read. Eleven forge PRs are in the same state today.
Two problems:
- Promotion is not deterministic end to end.
bot-promote-duecomputes what is due, but runningbot-pr promoteis left to a Sonnet dispatcher job started by the supervisor on anapprovalaction. Make the scheduled sweep (or a sibling timer unit) run the due promotions itself, with no model in the loop, and record each outcome on the board item. Keep the existing refusals (stale policy record, head moved since approval, human-text). - A refused promotion is silent. When an approval or
/promotecannot promote, comment once on the forge PR with the reason and the exact next step (for human-text: edit title, body and commits, then/promote --human-text), keyed so it is not repeated for the same head and reason. Forge PRs are in the bot's own org, so this adds no bot text upstream.
Open question for cgwalters: on human-text repos, should an approval made after he has edited the title and body himself count as /promote --human-text? Today it does not.
Tests: data-driven cases for due, refused-with-reason, already-commented, and head-moved.
Generated-by: https://github.com/cgwalters/#llms
Activity
cgwalters-bot commentedon Oct 5, 2026
Scope added from cgwalters's answer on #245: accept means the PR is posted upstream as the bot. Upstream LLM rules become an advisory warning shown on the forge PR before promote, blocking only when they clearly disallow bot accounts. Keep one issue that caches the bot's view of each org/repo contribution policy, and recheck a record when its sources changed since the last submission. The verdict flip for the eight silent repos is cgwalters-bot/homegit#145 (needs his approval).
Generated-by: https://github.com/cgwalters/#llms
cgwalters-bot commentedon Oct 6, 2026
Landed in cgwalters-bot/homegit#153 (and #151 reworked and merged).
bot-promote-due --apply; it now also promotes a human-text PR after/promote --human-text(bot-pr promotestill checks the text is yours), and reconcile no longer asks a model to runbot-pr promote.No gate or policy verdict changed. The open question (approval after your own edits counting as
/promote --human-text) is at cgwalters-bot/homegit#153 (comment). Advisory warning and cached policy view: #398.Generated-by: https://github.com/cgwalters/#llms
cgwalters-bot commentedon Oct 6, 2026
Post-merge review of cgwalters-bot/homegit#153 and #151 (read in full, not by Sonnet): both hold, nothing to fix.
bot-promote-dueonly decides when to runbot-pr promote, which checks the head, the policy and (for/promote --human-text) that the text is yours again; a stale approval never reaches it. Notices go only to open PRs by the bot in the forge or its own forks that carry a bot-meta section, never to the upstream PR, and only the bot's own comments count as notice keys or sign-off records. One comment per approval+head+reason (a moved head: per approval; a refusal: per approval+head, whatever its wording), so the 6h retry repeats nothing.closed_at; epics and anything with an open sub-issue stay; lookups are REST, archives go one at a time, 100 a run. Any unreadable item fails the run before a single archive.Two small things, yours to decide, not fixed:
/promote --human-textcan draw one "head moved" notice whose next step names plain/promote.Generated-by: https://github.com/cgwalters/#llms