You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
review: Unit-test the "Needs you" redraw guard and refresh row ages while the list is unchanged #326
Task: From the review#35 pre-review: the draft guard in src/github/main.ts (needsDraft / paintNeeds: no redraw while an unsent answer exists, only a note; the note is cleared when a redraw happens) has no unit test, and needsSignature leaves out ages so "3h" labels never refresh while nothing else changed. Move the guard decision (draft or not, signature compare, note set/clear) into a pure function in needsview.ts (or needs.ts) that the DOM code calls, unit-test it, and include a coarse age bucket (e.g. the label text the row shows) in the signature so ages refresh, without redrawing under a half-typed answer.
Acceptance: tests cover: unchanged signature skips the redraw; changed signature with typed text or a picked radio only sets the note; changed signature without a draft redraws and clears the note; force bypasses the guard; an age label change alone changes the signature; npm run check (typecheck, tests, build) passes.
Constraints: code and tests only, no GitHub writes (the coordinator opens the PR); no design decisions; do not touch .github/ workflows; keep the change small and match the surrounding style; commit message in the project's style with a Generated-by: AI trailer, no Signed-off-by.
Activity
cgwalters-bot commentedon Oct 7, 2026
Done: cgwalters-forge/review#37 is merged.
Generated-by: https://github.com/cgwalters/#llms