bootc: integration test for list_dev_by_dir_optional via internals #247

Activity

1. cgwalters-bot

   added

   target:bootc-dev

   P2

   on Sep 30, 2026
2. cgwalters-bot

   added this to Workstreamon Sep 30, 2026
3. cgwalters-bot

   added a parent issue on Sep 30, 2026

   • blockdev: list_dev_by_dir_optional (prep for coreos/bootupd#1163) #236
4. github-project-automation

   added this to Workstreamon Sep 30, 2026
5. cgwalters-bot

   removed a parent issue on Oct 7, 2026

   • blockdev: list_dev_by_dir_optional (prep for coreos/bootupd#1163) #236
6. cgwalters-bot

   added a parent issue on Oct 7, 2026

   • Epic: bootc and ostree family (parked) #333
7. cgwalters-forge

   locked as resolved and limited conversation to collaborators on Oct 18, 2026
8. cgwalters-bot commented on Oct 22, 2026

   

   cgwalters-bot

   on Oct 22, 2026

   Last edited by cgwalters-bot

   CollaboratorAuthor

   More actions

   ✅ dispatch ended well. Result: #247 (comment)
9. cgwalters-bot commented on Oct 22, 2026

   

   cgwalters-bot

   on Oct 22, 2026

   CollaboratorAuthor

   More actions

   Valid, and already implemented. It needs the operator's review, not another run. The draft fork PR cgwalters-forge/bootc#34 ("cli: Add blockdev ls-filesystem --optional, test it booted", opened 30 Sep by cgwalters-bot) does exactly what this issue asks. It has had no review since then.

   What I checked:

   • Upstream bootc-dev/bootc#2517 was merged on 30 Sep. On upstream main (de7ae55), list_dev_by_dir_optional is still called only from its own unit test (/proc). bootc internals blockdev ls-filesystem still only calls list_dev_by_dir. So the gap is real upstream.
   • bootupd CI: composefs e2e boot broken by bootc composefs.digest= karg vs 1.16 initramfs #34 adds --optional to ls-filesystem, which prints null when there is no backing block device. It also adds tmt/tests/booted/readonly/016-test-blockdev-optional.nu, which covers /sysroot (real disk, same result as without the flag), / (a device, or null on a composefs overlay), and /proc (null, and the plain command fails). It also covers a tmpfs and an overlayfs, each mounted in a private mount namespace. The PR description says just validate, the unit tests and readonly tmt passed for both ostree and composefs on devspaces. Fork CI is off, so I couldn't check this.
   • GitHub reports bootupd CI: composefs e2e boot broken by bootc composefs.digest= karg vs 1.16 initramfs #34 as mergeable: clean against the fork's main. The fork's main is one commit behind upstream, and that commit only changes ADOPTERS.md. No other PR, upstream or on the fork, touches this.

   Decision for @cgwalters: review #34. The options:

   • (a) Approve as it is, or comment /promote. This opens it upstream.
   • (b) Ask for a separate internals subcommand instead of the --optional flag. This is open question 1 on the PR.
   • (c) Close it if the unit test from #2517 is enough.

   Open question 2 on the PR: the test VMs have no virtiofs mount, so virtiofs isn't tested. tmpfs and overlay go through the same st_dev major-0 path, and I think that is enough. A nit you might raise: there is already a readonly/016-test-blockdev-no-udev.nu, so the new test shares the number 016. That only affects the order the tests run in. Once the upstream PR merges, this issue can be closed as completed.

   Generated-by: https://github.com/cgwalters/#llms

   Generated by dispatch · ◷