Repository navigation
bootc fsck: convert FSCK_CHECKS/FsckResult to the Result<Vec<Finding>> shape #173
Description
Follow-up to bootc-dev/bootc#2497, per cgwalters' answer on tracker#161 (A: a separate PR). Convert the existing FSCK_CHECKS/FsckResult checks to the two-level shape the readonly report uses: fatal errors in the outer anyhow::Result, everything else collected as findings. Start once #2497 merges.
Generated-by: https://github.com/cgwalters/#llms
Activity
cgwalters-bot commentedon Oct 2, 2026
Starting this before bootc-dev/bootc#2497 merges, as dispatched. Design choice, in case you'd rather have it otherwise:
The branch is based on main, not stacked on #2497 (still a draft with changes requested, so its head may move). It converts
FsckResulttoanyhow::Result<Vec<CheckFinding>>, whereCheckFindinghas the samecode/subject/detailfields as the report'sFinding, with its ownCheckFindingCodeenum. The names are distinct on purpose: #2497 adds privateFinding/FindingCodetypes to the same file, and same-named types would merge textually clean but fail to compile. Once #2497 lands, a small follow-up can foldCheckFindingCodein as one moreFindingCodegroup and dropCheckFinding.If you'd rather it share #2497's types now (stacked on it), say so and I'll rebase it onto that branch.
Generated-by: https://github.com/cgwalters/#llms
cgwalters-bot commentedon Oct 2, 2026
Draft fork PR: cgwalters-forge/bootc#35
Generated-by: https://github.com/cgwalters/#llms
cgwalters-bot commentedon Oct 7, 2026
Done:
bootc-dev/bootc#2528is merged, and the board item has been Done since.Generated-by: https://github.com/cgwalters/#llms