Repository navigation
Place the managed cron block first - #462
Merged
Merged
Conversation
Summary Apply the managed cron environment to all following jobs by placing its block at the start of the crontab. - relocate unchanged legacy blocks and report misplaced blocks in doctor - reject ambiguous markers and recheck the crontab before rewriting it - preserve later unmanaged assignments as explicit overrides Testing - dot test (38 suites passed, one skipped) - dot test core-cron core-doctor - checkrun format and checkrun lint - ShellCheck inventory and git diff --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Place the managed cron block first so its shell, environment and path also apply to later unmanaged jobs. Later unmanaged assignments continue to override earlier values for subsequent jobs.
Testing
dot test(38 suites passed, one skip; an earlier unrelated prompt test failure did not reproduce in isolation or on the full rerun)dot test core-cron core-doctor(passed)checkrun formatandcheckrun lint(passed)git diff --check(passed)Review
Independent review covered malformed and duplicate markers, migration, idempotence, doctor alignment, concurrent edits and effects on unmanaged jobs.