fix(webapp): match ended card to the house section-heading style#28
Merged
Conversation
On the off-season ended.html, two stacked cards looked like different species. The "Don't miss next season" reminder card uses the app's house heading style `.welcome` (centered, pumpkin, glowing) with a 16px muted `.remind-blurb` body, while "The Long Night has ended." above it was a bare <h3> (off-white, left-aligned, no glow, trailing period) with an 18px <h5> body -- the only section heading in the app not using `.welcome`. - ended.html: give the ended card the same `.forms` + `.welcome` + `.remind-blurb` treatment as the reminder card so the two read as siblings (drop the period, centered pumpkin glow heading, 16px muted body); shorten the reminder blurb so it wraps to ~2 lines. - login.html / profile.html: close the unclosed <p> on the intro line. Template-only -- no CSS, Python, dependency, or behavior change. Verified with browser QA on ended.html (sandbox season forced closed) and the full pytest suite (86 passing). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No blocking issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
On the off-season
ended.html, two stacked cards rendered like different species. The newer "Don't miss next season" reminder card uses the app's house section-heading style.welcome(centered, pumpkin, glowing) with a 16px muted.remind-blurbbody. The older "The Long Night has ended." card above it was a bare<h3>(off-white, left-aligned, no glow, trailing period) with an 18px<h5>body — the only section heading in the app not using.welcome.Changes (templates only)
ended.html— the ended card now mirrors the reminder card (.forms+.welcome+.remind-blurb): centered pumpkin glowing heading, no trailing period, 16px muted body, so the two cards read as matched siblings. The reminder blurb is shortened to wrap to ~2 lines.login.html/profile.html— close the unclosed<p>on the intro line.Deliberately not touched: the GOT-font brand family (header / footer / Top Score / Scan) — an intentional, internally consistent brand voice, not an inconsistency.
Verification
ended.html(sandbox season forced closed) on phone + laptop — both cards confirmed as matched siblings, period gone, blurb wraps to 2 lines.No CSS, Python, dependency, or behavior change.
VERSIONis build-stamped from the CI SHA, so it is not bumped.🤖 Generated with Claude Code