ci: tighten auto-review prompt + add accepted-trade-offs list#23
Merged
Conversation
Scope the Claude PR reviewer to the diff, set a confidence bar (real bug/security/regression only), tag findings must-fix/should-fix, drop nits/praise, and update one summary in place (gh pr comment --edit-last --create-if-none) instead of stacking a new comment per push. Honor CLAUDE.md's accepted trade-offs and never "correct" a documented decision. Add a "Review scope - accepted trade-offs" list to CLAUDE.md (the reviewer reads it) as the human-in-the-loop ignore-memory, seeded with the settled decisions: werkzeug prod server, in-memory sessions, self-signed cert, camelCase, mutable @vn action tags, and the 401-by-design self-review fail. Model unchanged (Pro default / Sonnet) - the issues were prompt/scope, not capability. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tunes the automated Claude PR reviewer to cut noise and re-litigation, and adds a durable "what to ignore" list it reads.
Why
Reviewing the bot's history (PRs #16–22) surfaced four issues, all prompt/process — not model capability:
gh pr commentposts a new comment every run; PR ci: future-proof action versions + stop no-op .github redeploys #22 fired 3 runs (one per push) and stacked 2 near-identical summaries.Changes
.github/workflows/claude-review.yml(prompt only):--edit-last --create-if-none) instead of one per push.CLAUDE.md:@vNaction tags (so upstream fixes land ASAP), and the 401-by-design self-review failure.Model unchanged (Pro default / Sonnet 4.6) — Opus would phrase the same out-of-scope nits more eloquently and draws extra paid usage on Pro.
Notes
401 Workflow validation failed) — expected, ignorable, doesn't block merge.changesfilter, so merging won't rebuild the image or redeploy the Pi. The new prompt takes effect on the next code PR.🤖 Generated with Claude Code