This repository was archived by the owner on Feb 7, 2026. It is now read-only.
use duck typing and exceptions as well as spaces instead of tabs - #40
Open
jihoon796 wants to merge 3 commits into
Open
use duck typing and exceptions as well as spaces instead of tabs#40jihoon796 wants to merge 3 commits into
jihoon796 wants to merge 3 commits into
Conversation
jihoon796
commented
Dec 28, 2015
jihoon796
commented
Owner
There was a problem hiding this comment.
i believe it should be alphabetical by module name.. so:
import datetime
from urllib import urlencode
from urllib2 import Request, urlopen
Author
There was a problem hiding this comment.
Ok, fixed now - thanks!
On Sun, Dec 27, 2015 at 11:23 PM, Corey Goldberg notifications@github.com
wrote:
In ystockquote.py
#40 (comment):from urllib import urlencode
- from urllib2 import Request, urlopen
- import datetime
i believe it should be alphabetical by module name.. so:
import datetime
from urllib import urlencode
from urllib2 import Request, urlopen—
Reply to this email directly or view it on GitHub
https://github.com/cgoldberg/ystockquote/pull/40/files#r48462722.
Author
|
Hey Corey, please merge if everything looks good - otherwise, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.