fix(monitor): reprime re-added wallets#122
Draft
cgfixit wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TradeMonitor.set_wallets().Why
Previously, a removed wallet retained its primed marker. If it returned later, its first poll could treat trades accumulated during the gap as new. The existing staleness gate is not a substitute for the cold-start guard.
Verification
python -m pytest tests/test_monitor.py -q -p no:cacheprovider— 56 passedpython -m pytest -m "not integration" -q -p no:cacheprovider— 625 passedpowershell -NoProfile -ExecutionPolicy Bypass -File scripts/check-lint.ps1python -m mypy polymarket_copier --ignore-missing-imports --no-strict-optionalpython -m py_compile polymarket_copier/core/monitor.py tests/test_monitor.pygit diff --checkScope and risk
Monitor state only. No trading math, position sizing, order behavior, live-mode gate, or credentials changed. Retained wallets keep their existing priming state and seen IDs.