test: consume heartbeat wait coroutines#114
Merged
Merged
Conversation
cgfixit
marked this pull request as ready for review
July 13, 2026 02:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
asyncio.wait_fortest stubs with per-eventEvent.waitstubs.Why
The tests passed while leaving each
Event.wait()coroutine unconsumed. Onorigin/main, the focused run reported 3 passed with 5RuntimeWarning: coroutine 'Event.wait' was never awaitedwarnings. Promoting those warnings to errors exposed the test defect.This is tests-only. Production code, trading behavior, configuration, and dependencies are unchanged.
Validation
origin/main: focused heartbeat run -> 3 passed, 5 RuntimeWarningspython -m pytest tests/test_monitor.py::TestTradeMonitor::test_ws_heartbeat_sends_polymarket_ping tests/test_monitor.py::TestTradeMonitor::test_ws_heartbeat_subscription_wake_does_not_ping tests/test_monitor.py::TestMonitorRunAndSubscriptionRefresh::test_ws_heartbeat_pushes_subscription_update -q -W error::RuntimeWarning-> 3 passedpython -m pytest tests/test_monitor.py -q -W error::RuntimeWarning-> 54 passedpython -m pytest -v -m "not integration"-> 624 passedpowershell -File scripts/check-lint.ps1-> Ruff lint and format passedpython -m mypy polymarket_copier --ignore-missing-imports --no-strict-optional-> successgit diff --check-> cleanRisk To Monitor
Low. The change only narrows test mocking from the global scheduler helper to the heartbeat's event wait method. CI timing and production runtime behavior are unaffected.