Conversation
…download in CI find on a non-existent subdirectory exits 1, which aborts the entrypoint under set -euo pipefail before mypy/pytest ever run. Fix: search from the base fastembed dir (always present after mkdir -p) with -path filters. Also skip the model download entirely in CI (GitHub Actions sets CI=true) — the ephemeral runner has no persistent cache and models are not needed for mypy or pytest.
fix: entrypoint find never fails under set -euo pipefail; skip model download in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the entrypoint CI fix (#1182) into main so CI passes.