Use POST instead of GET to avoid plain text passwords in logs.#27
Open
jlrgraham wants to merge 1 commit into
Open
Use POST instead of GET to avoid plain text passwords in logs.#27jlrgraham wants to merge 1 commit into
jlrgraham wants to merge 1 commit into
Conversation
Use the HTTP POST method to interact with the Fully Kiosk instances instead of GET. We move the "password" value into the URL encoded body of the POST request and that prevents it from being placed in DEBUG logs or other exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the HTTP POST method to interact with the Fully Kiosk instances instead of GET. We move the "password" value into the URL encoded body of the POST request and that prevents it from being placed in DEBUG logs or other exceptions.
Limited testing on my setup seems happy with this, but I didn't test (as I do not use) all
cmdvalues that are present.