[pull] master from microsoft:master#115
Merged
Merged
Conversation
The merge of #2002 (prefetch-offload-to-mount) on top of #2004 (expand-prefetch-cache) left three issues: 1. PrefetchVerb.cs hydration-fallback path passed the removed lastPrefetchArgs variable instead of prefetchCache + prefetchCacheSize. 2. InProcessMount.cs HandlePrefetchBlobsRequest passed the removed lastPrefetchArgs variable. The mount-side handler is a one-shot download with no persistent noop cache, so it correctly receives null + 0. 3. When prefetch succeeds via mount offload, the verb-side noop cache was never updated — SavePrefetchArgs only runs inside BlobPrefetcher.PrefetchWithStats, which is skipped on the offload path. This caused NoopPrefetch to re-download on the second run instead of printing 'Nothing new to prefetch.' Fix: add BlobPrefetcher.UpdateNoopCache() static method (extracted from SavePrefetchArgs logic) and call it from PrefetchVerb after successful mount offload. Update PrefetchBlobsMountedAfterRemount test to expect the noop message since the file was already cached by a prior test in the same fixture. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Fix build break: bad merge in prefetch cache parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )