Skip to content

refactor(menubar): chrome-flock coordinator [P17.03] #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cesarnml wants to merge 9 commits into from
Closed

refactor(menubar): chrome-flock coordinator [P17.03] #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
15f87af
test(P17.03): pin AttentionBubbleLayout anchor geometry ahead of extr…
cesarnml Jul 12, 2026
422b019
feat(P17.03): add ChromeFlockCoordinator, promote AttentionBubbleLayo…
cesarnml Jul 12, 2026
8f00ae4
refactor(P17.03): migrate Own mode onto the chrome-flock coordinator …
cesarnml Jul 12, 2026
3ab6a24
refactor(P17.03): migrate Minimalist mode onto the chrome-flock coord…
cesarnml Jul 12, 2026
89b25b7
docs(P17.03): record chrome-coordinator rationale — scope, deferrals,…
cesarnml Jul 12, 2026
092ceea
refactor(P17.03): remove unused hideHUDImmediately helper [post-verify]
cesarnml Jul 12, 2026
bf649e6
chore(P17.03): record subagent adversarial review prompt
cesarnml Jul 12, 2026
3093d15
chore(P17.03): record subagent-review runner artifact
cesarnml Jul 12, 2026
18f8827
chore(delivery): commit PR review artifacts after record-review P17.03
cesarnml Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions apps/menubar/Codogotchi.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@
69FAC7752922A70F4943791A /* FloatingPetPromptBuilder.swift in Sources */ = {isa = PBXBuildFile; fileRef = A9C3594285193B88B858A1C8 /* FloatingPetPromptBuilder.swift */; };
6A6E965676C08DCF5EA44900 /* PromptTimerChipView.swift in Sources */ = {isa = PBXBuildFile; fileRef = D1D8D2C351C51A43AE40A1A6 /* PromptTimerChipView.swift */; };
6A78A39CED185B02C213FE62 /* MenuItemsTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = E06FB02C825E53E28CCC8205 /* MenuItemsTests.swift */; };
6B58522CFED9FDE9D156C4BF /* AttentionBubbleLayoutTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 773ED3F1BAFCB9F4F7CF721E /* AttentionBubbleLayoutTests.swift */; };
6BE7F6EA53A623C22C0B98E5 /* RPGHUDIconTileView.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6858ADF75A07FF4C263F283 /* RPGHUDIconTileView.swift */; };
6DA9D60EB6FA048B64876A79 /* RPGHUDPanel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 349466D86E4C96C4D4A098BD /* RPGHUDPanel.swift */; };
708062CE5FDA296BC26AF17C /* PetTabLayoutTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 777877051ED12A63B5FD6ACB /* PetTabLayoutTests.swift */; };
Expand Down Expand Up @@ -149,6 +150,7 @@
C36FF6AE70AA258CB1606191 /* GeneralTabViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4230D08B6B3DE5647616FFB5 /* GeneralTabViewModel.swift */; };
C3CF7A5143344F4CAB118216 /* GeneralTabView.swift in Sources */ = {isa = PBXBuildFile; fileRef = CB255569CEB14B591E936A83 /* GeneralTabView.swift */; };
C4F4151A25F6ED0D587172FD /* StateJsonReaderTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 9E5A328D013E03984657DE8F /* StateJsonReaderTests.swift */; };
C529C89964AAE3CFD2E410A4 /* ChromeFlockCoordinator.swift in Sources */ = {isa = PBXBuildFile; fileRef = FE8CCE564BDB7258EEE9F3C0 /* ChromeFlockCoordinator.swift */; };
C6262A26295AA1B037EE560F /* RetrievedSessionTitleStore.swift in Sources */ = {isa = PBXBuildFile; fileRef = 12FBBDE3DDE80E6CF81054CE /* RetrievedSessionTitleStore.swift */; };
C81091A2187453263DAF99B7 /* CodexPetTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 4610C19ADA41987592CEE748 /* CodexPetTests.swift */; };
C869CD78C14ADFF9F38EBDB9 /* GateJsonReaderTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = D97B6CBA3971EF14695D74F9 /* GateJsonReaderTests.swift */; };
Expand Down Expand Up @@ -290,6 +292,7 @@
739A5B92AC38A1366A5AA520 /* AboutTabView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AboutTabView.swift; sourceTree = "<group>"; };
753D06BA7617A23E1D9A4113 /* DeveloperTabViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DeveloperTabViewModel.swift; sourceTree = "<group>"; };
76C6A4BBDE3D1AC70D3BCD82 /* AppState.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppState.swift; sourceTree = "<group>"; };
773ED3F1BAFCB9F4F7CF721E /* AttentionBubbleLayoutTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AttentionBubbleLayoutTests.swift; sourceTree = "<group>"; };
777877051ED12A63B5FD6ACB /* PetTabLayoutTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PetTabLayoutTests.swift; sourceTree = "<group>"; };
77AD5E672E750D5D5DC5CED8 /* WindowKey.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = WindowKey.swift; sourceTree = "<group>"; };
78115EE1CE4F0AFD41CC1231 /* RPGHUDViewModelTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = RPGHUDViewModelTests.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -395,6 +398,7 @@
F4B2DA7902212941A3DBFFE0 /* AboutViewModelTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AboutViewModelTests.swift; sourceTree = "<group>"; };
F5CF055F2A0C9DD84F4F026A /* FloatingPetWindowPool.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FloatingPetWindowPool.swift; sourceTree = "<group>"; };
F91F037388E6AEB00DBBC86A /* SettingsTabModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SettingsTabModel.swift; sourceTree = "<group>"; };
FE8CCE564BDB7258EEE9F3C0 /* ChromeFlockCoordinator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ChromeFlockCoordinator.swift; sourceTree = "<group>"; };
FED1E6B27BAC9CB8CAE40022 /* FlippedStackView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FlippedStackView.swift; sourceTree = "<group>"; };
/* End PBXFileReference section */

Expand All @@ -421,6 +425,7 @@
5F486C5A7F91BAF4B1E38E58 /* AppBootstrapTests.swift */,
B8F15B1B99434EA9F9005052 /* AppStateTests.swift */,
B088460D34832B339123365F /* AssignmentsJsonReaderTests.swift */,
773ED3F1BAFCB9F4F7CF721E /* AttentionBubbleLayoutTests.swift */,
F38C436FB78D4B7E7895A7EA /* AttentionFocusTargetTests.swift */,
1445A1864D6A3164B047FB24 /* AttentionSubtitleFormattingTests.swift */,
9E7256729C3F274DFB3A5204 /* BundledMaewTests.swift */,
Expand Down Expand Up @@ -538,6 +543,7 @@
4E9E9356DD0466C7E29F5783 /* AnimationLabelPillView.swift */,
195864BAFD9024E422A5CDF7 /* AttentionBubblePanel.swift */,
2A3F3FFB7DF8572D37B7C3F1 /* AttentionSubtitleFormatting.swift */,
FE8CCE564BDB7258EEE9F3C0 /* ChromeFlockCoordinator.swift */,
A99F6A33E762533EA412019B /* ConflictBubblePayload.swift */,
9310785E0303F2C6627ADAE4 /* ConflictBubbleRateLimiter.swift */,
5A1164CB8566A5AEAA80BA69 /* ConflictBubbleTargetSelector.swift */,
Expand Down Expand Up @@ -815,6 +821,7 @@
25296F59318459AC7DF83336 /* AttentionBubblePanel.swift in Sources */,
94517E2D23A71B04A73DF372 /* AttentionSubtitleFormatting.swift in Sources */,
44C2550A80D96292C3200AA3 /* BadgeRowView.swift in Sources */,
C529C89964AAE3CFD2E410A4 /* ChromeFlockCoordinator.swift in Sources */,
DCD225D3384F315C78D5D4F7 /* CodexPet.swift in Sources */,
2DE5757A1AB31EA244306A07 /* CodogotchiFolders.swift in Sources */,
EA5D31903A8F315299EBD9D6 /* CodogotchiPet.swift in Sources */,
Expand Down Expand Up @@ -935,6 +942,7 @@
2C985DFC0C4B11F3C3BF69F9 /* AppBootstrapTests.swift in Sources */,
BA3F2EF6D3F5E093C9DFFBE9 /* AppStateTests.swift in Sources */,
66B5C50B58C2A0D21B2D59A6 /* AssignmentsJsonReaderTests.swift in Sources */,
6B58522CFED9FDE9D156C4BF /* AttentionBubbleLayoutTests.swift in Sources */,
EDE94984953A0853B0FE255B /* AttentionFocusTargetTests.swift in Sources */,
541D53E7148183452D2632E0 /* AttentionSubtitleFormattingTests.swift in Sources */,
99C8B80FE0466C9BB1B58C51 /* BundledMaewTests.swift in Sources */,
Expand Down
27 changes: 18 additions & 9 deletions apps/menubar/Sources/Windows/AttentionBubblePanel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,16 @@ import Foundation

// MARK: - Layout

private enum BubbleLayout {
/// Anchor math and view-styling constants for `AttentionBubblePanel`. Own
/// mode and Minimalist mode both call `frame(relativeTo:leadingX:bottomAnchorY:visibleFrame:)`
/// with their own `leadingX`/`bottomAnchorY` inputs (see
/// `docs/contracts/window-capability-matrix.md` R3.7) — this type is the
/// coordinator-consumable, unit-tested home for that shared math. Promoted
/// out of a file-private `BubbleLayout` enum (P17.03) so it has the same
/// pure-function + test-coverage shape as its four sibling panel-layout
/// types (`AnimationBadgeLayout`, `GateBadgeLayout`, `SpeechBubbleLayout`,
/// `RPGHUDLayout`).
enum AttentionBubbleLayout {
static let minWidth: CGFloat = 200
static let maxWidth: CGFloat = 280
static let height: CGFloat = 58
Expand Down Expand Up @@ -160,7 +169,7 @@ final class AttentionBubblePanel: NSPanel {
func reposition(
relativeTo petFrame: CGRect, leadingX: CGFloat, bottomAnchorY: CGFloat, visibleFrame: CGRect
) {
let f = BubbleLayout.frame(
let f = AttentionBubbleLayout.frame(
relativeTo: petFrame, leadingX: leadingX, bottomAnchorY: bottomAnchorY, visibleFrame: visibleFrame)
setFrame(f, display: true)
bubbleView.frame = NSRect(origin: .zero, size: f.size)
Expand Down Expand Up @@ -359,8 +368,8 @@ private final class AttentionBubbleView: NSView {
actionButton.translatesAutoresizingMaskIntoConstraints = false
addSubview(actionButton)

let hPad = BubbleLayout.hPad
let vPad = BubbleLayout.vPad
let hPad = AttentionBubbleLayout.hPad
let vPad = AttentionBubbleLayout.vPad

NSLayoutConstraint.activate([
// background
Expand All @@ -386,14 +395,14 @@ private final class AttentionBubbleView: NSView {
// close button — hover-only circle, floating over the bubble chrome.
dismissButton.leadingAnchor.constraint(equalTo: leadingAnchor, constant: hPad - 1),
dismissButton.centerYAnchor.constraint(equalTo: summaryLabel.centerYAnchor),
dismissButton.widthAnchor.constraint(equalToConstant: BubbleLayout.closeButtonSize),
dismissButton.widthAnchor.constraint(equalToConstant: AttentionBubbleLayout.closeButtonSize),
dismissButton.heightAnchor.constraint(equalTo: dismissButton.widthAnchor),

// action button — hover-only pill, right-aligned with the bubble body.
actionButton.trailingAnchor.constraint(equalTo: trailingAnchor, constant: -hPad),
actionButton.bottomAnchor.constraint(equalTo: bottomAnchor, constant: -vPad),
actionButton.widthAnchor.constraint(equalToConstant: BubbleLayout.actionButtonWidth),
actionButton.heightAnchor.constraint(equalToConstant: BubbleLayout.actionButtonHeight),
actionButton.widthAnchor.constraint(equalToConstant: AttentionBubbleLayout.actionButtonWidth),
actionButton.heightAnchor.constraint(equalToConstant: AttentionBubbleLayout.actionButtonHeight),
])

applyChromeStyle()
Expand Down Expand Up @@ -510,9 +519,9 @@ private final class AttentionBubbleView: NSView {
}

private func applyChromeStyle() {
effectView.layer?.cornerRadius = BubbleLayout.cornerRadius
effectView.layer?.cornerRadius = AttentionBubbleLayout.cornerRadius
effectView.layer?.masksToBounds = true
layer?.cornerRadius = BubbleLayout.cornerRadius
layer?.cornerRadius = AttentionBubbleLayout.cornerRadius
layer?.borderColor = NSColor.white.withAlphaComponent(0.20).cgColor
layer?.borderWidth = 1
layer?.shadowColor = NSColor.black.cgColor
Expand Down
Loading