Fix always-truthy if expression in _detect_changes.yml#242
Open
pdelsante wants to merge 1 commit into
Open
Conversation
The "Generate summary" step's if condition combined three separate
${{ }} expressions with literal | characters, which GitHub Actions
treats as literal text outside the replacement tokens - making the
whole condition always evaluate to truthy regardless of input values.
Combine into a single expression using the || operator instead.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generate summarystep in_detect_changes.ymlcombined three separate${{ }}expressions with literal|characters outside the replacement tokens, which GitHub Actions treats as literal text — making the condition always evaluate to truthy regardless of input values (surfaced as a workflow syntax warning when consumed downstream, e.g. certego/certego-tools#328).${{ }}expression using the||operator.workflows/_detect_changes.ymland.github/workflows/_detect_changes.yml).Test plan
Generate summarystep still runs when any ofbackend_directories/frontend_directories/infrastructure_directoriesis non-empty, and is skipped when all are empty🤖 Generated with Claude Code