properly handle script and style tags so they are rendered as they should be - #17
Open
tobymackenzie wants to merge 1 commit into
Open
properly handle script and style tags so they are rendered as they should be#17tobymackenzie wants to merge 1 commit into
tobymackenzie wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt at fixing issue #16, wherein script and style tags are not rendered as they should be. My test mostly comes out as expected, though a bit of the comments from one of the CDATA style comment wrappers is showing up. I'm not sure if this is what would happen in actual line mode or not.
The changes to prepare.js are the important ones for the node served lmb. The changes to linemodethis.js are apparently for a bookmarklet, though I'm not sure how to use it.
This is my first pull request, so let me know if I'm doing something wrong.