include <cstdint> wherever missing#48
Closed
rishabh-d-dave wants to merge 1 commit into
Closed
Conversation
Fixes errors like this that are seen while building Ceph repo's main branch on Fedora 46, 43 and 44 - repos/ceph/src/rocksdb/include/rocksdb/trace_record.h:55:32: error: expected ‘)’ before ‘timestamp’ 55 | explicit TraceRecord(uint64_t timestamp); Signed-off-by: Rishabh Dave <ridave@redhat.com>
rishabh-d-dave
force-pushed
the
ceph-umbrella-stdint
branch
from
0e459b5 to
a2cc511
Compare
Author
|
It's on similar lines as #47 but the change to blob_file_meta.h is skipped as it was fixed by a recent commit. |
rzarzynski
approved these changes
Jun 19, 2026
|
We'll need to bump up the |
|
we should cherry-pick upstream change (see facebook@58420b7) instead of carrying our own |
done. |
created ceph/ceph#69596 |
Author
|
Closing in favour of ceph/ceph#69596. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes errors like this that are seen while building Ceph repo's main
branch on Fedora 42, 43 and 44 -