Fix start screen colors in light mode#1
Open
Xuyiyang23333 wants to merge 1 commit into
Open
Conversation
Xuyiyang23333
marked this pull request as ready for review
July 17, 2026 08:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The start screen's material and Liquid Glass appearance adapt between light and dark mode, but its foreground colors were hard-coded to white. In light mode this produced low-contrast text and controls on the lighter panel.
Using
.primary,.secondary, andColor.primary.opacity(...)allows the foreground and control chrome to follow the system appearance together with the panel.Validation
xcodebuild -project Consolation.xcodeproj -scheme Consolation -configuration Release -destination 'platform=macOS' ... build(BUILD SUCCEEDED)git diff --check