Report TypeError raised inside a view as a Server error - #756
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Signed-off-by: say <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #755.
A
TypeErrorraised inside a view (from the view's own logic, not from parameter validation) was caught by the same handler that maps typeguard's argument checking toInvalidParamsError, so the caller got a400Invalid params response instead of a500Server error.typeguard reports argument type mismatches as
TypeCheckError(which is not aTypeError), so the view call is now wrapped in a narrower handler that only convertsTypeCheckErrortoInvalidParamsError. A plainTypeErrorfrom the view body propagates and is reported as a Server error, while binding and annotated-metadata failures still map to Invalid params. Added a regression test intest_site.py.